Fix strip spec-mandated DV blob framing before deserializing#3576
Merged
Conversation
Fokko
reviewed
Jun 30, 2026
|
|
||
| class PuffinBlobMetadata(IcebergBaseModel): | ||
| type: Literal["deletion-vector-v1"] = Field() | ||
| type: str = Field() |
Contributor
There was a problem hiding this comment.
What's the reason behind this change? I think it would be better to be strict in what we allow as a type. WDYT?
Member
Author
There was a problem hiding this comment.
Otherwise, we can't test sample-metric-data-uncompressed.bin - download from Iceberg Java repository. It doesn't contain deletion-vector-v1 type.
I understand the motivation behind the existing guard, but Puffin file itself doesn't restrict the types it can contain.
Contributor
There was a problem hiding this comment.
I see, that's reasonable. Thanks 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fix
_payloadstoringpuffin[8:]instead ofpuffin— blob offsetsin the footer are file-relative (from byte 0), not relative to byte 8.
The two bugs cancelled for single-blob files at offset 4; the fix was
only testable once PuffinFile supported multi-blob/compressed files.
Also widen
PuffinBlobMetadata.typefromLiteral["deletion-vector-v1"]to
strsoPuffinFilecan parse files containing non-DV blobs withouta Pydantic validation error.
Are these changes tested?
Yes. Copied files from https://github.com/apache/iceberg/tree/main/core/src/test/resources/org/apache/iceberg/puffin/v1
sample-metric-data-compressed-zstd.binwill be added separately in #3575Are there any user-facing changes?
No